Merged
Conversation
roji
force-pushed
the
main
branch
2 times, most recently
from
249ae47 to
6b86657
Compare
cincuranet
force-pushed
the
isnullconstant
branch
from
5aeebbd to
79cc5c5
Compare
There was a problem hiding this comment.
Pull request overview
This PR simplifies internal null-constant checks in query expression visitors by inlining pattern matching instead of using small private helper methods. The behavior is preserved while slightly reducing indirection.
Changes:
- In
QueryOptimizingExpressionVisitor, inline theIsNullConstanthelper logic directly into the conditional optimization and remove the unused private helper. - In
InMemoryExpressionTranslatingExpressionVisitor, inline theIsNullConstantExpressionhelper logic into the entity-equality rewrite path and delete the now-unneeded private helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/EFCore/Query/Internal/QueryOptimizingExpressionVisitor.cs |
Replaces calls to a private IsNullConstant helper with inline ConstantExpression { Value: null } pattern checks and removes the helper, preserving the conditional rewrite semantics. |
src/EFCore.InMemory/Query/Internal/InMemoryExpressionTranslatingExpressionVisitor.cs |
Inlines null-constant detection for entity-equality rewrites using pattern matching and removes the redundant private helper, leaving existing extension-based null checks elsewhere unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.